-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for the "type qualifiers" section of the typing spec #1554
Conversation
Added tests for `@final` decorator. Added tests for `Final` annotation. Updated pyright test results for latest version (1.1.344). Added tests for Annotated.
…nd staticmethod implementations of protocol.
@hauntsaninja, @JelleZijlstra, this is ready for review (and merging) when you have a chance. This PR includes conformance tests for the following chapters of the spec:
I realize there's a lot here to review. It's probably not worth going through every line of every test at this time. As with my earlier PR, none of this is set in stone, and we should be open to making changes later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still going through it, pausing for dinner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, finished my pass through the test cases!
I don't know that all comments need to be addressed for this PR to be merged; if you leave any comments marked unresolved I'll follow up separately
And thank you again for for leading the charge on this! :-) |
Added link to conformance results.
Updated pyright test results for latest version (1.1.344).
Added tests for
@final
decorator.Added tests for
Final
annotation.Added tests for Annotated.