Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for the "type qualifiers" section of the typing spec #1554

Merged
merged 13 commits into from
Jan 5, 2024

Conversation

erictraut
Copy link
Collaborator

Added link to conformance results.
Updated pyright test results for latest version (1.1.344).
Added tests for @final decorator.
Added tests for Final annotation.
Added tests for Annotated.

Added tests for `@final` decorator.

Added tests for `Final` annotation.

Updated pyright test results for latest version (1.1.344).

Added tests for Annotated.
@erictraut
Copy link
Collaborator Author

@hauntsaninja, @JelleZijlstra, this is ready for review (and merging) when you have a chance.

This PR includes conformance tests for the following chapters of the spec:

  • Type Annotations
  • Special Types used in Annotations
  • Type Qualifiers
  • Protocols
  • Overloads
  • Type Checker Directives
  • Classes

I realize there's a lot here to review. It's probably not worth going through every line of every test at this time. As with my earlier PR, none of this is set in stone, and we should be open to making changes later.

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still going through it, pausing for dinner

conformance/tests/annotations_coroutines.py Outdated Show resolved Hide resolved
conformance/tests/annotations_generators.py Show resolved Hide resolved
conformance/tests/annotations_forward_refs.py Outdated Show resolved Hide resolved
conformance/tests/annotations_methods.py Show resolved Hide resolved
conformance/tests/annotations_methods.py Show resolved Hide resolved
conformance/tests/directives_no_type_check.py Show resolved Hide resolved
conformance/tests/directives_reveal_type.py Show resolved Hide resolved
conformance/tests/directives_type_ignore.py Show resolved Hide resolved
conformance/tests/overloads_basic.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, finished my pass through the test cases!

I don't know that all comments need to be addressed for this PR to be merged; if you leave any comments marked unresolved I'll follow up separately

conformance/tests/protocols_definition.py Show resolved Hide resolved
conformance/tests/protocols_definition.py Outdated Show resolved Hide resolved
conformance/tests/protocols_definition.py Show resolved Hide resolved
conformance/tests/protocols_explicit.py Show resolved Hide resolved
conformance/tests/protocols_generic.py Show resolved Hide resolved
conformance/tests/protocols_merging.py Show resolved Hide resolved
conformance/tests/protocols_modules.py Show resolved Hide resolved
conformance/tests/protocols_definition.py Show resolved Hide resolved
conformance/tests/protocols_modules.py Show resolved Hide resolved
conformance/tests/specialtypes_promotions.py Show resolved Hide resolved
@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Jan 4, 2024

And thank you again for for leading the charge on this! :-)

@hauntsaninja hauntsaninja merged commit 69d7412 into python:main Jan 5, 2024
3 checks passed
@erictraut erictraut deleted the conformance-test-part2 branch April 14, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants