Make pytype conformance test a little faster. #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change gets the pytype test down to ~30s. It's still considerably slower than the others, but any further improvements will likely require untangling the sad state of affairs that is google/pytype#1501, which will take some time. * Runs pytype's 'check' option through pytype.io.check_py to skip the costly type inference that it does by default. * Adds a progress bar so that it doesn't look like pytype is hanging. This generates a few changes to results/pytype/ due to error messages being formatted and parsed in a different way.
|
All commit authors signed the Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gets the pytype test down to ~30s. It's still considerably slower than the others, but any further improvements will likely require untangling the sad state of affairs that is
google/pytype#1501, which will take some time.
This generates a few changes to results/pytype/, mostly due to error messages being formatted and parsed differently.