Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernise more description in stubs distribution #1577

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

hauntsaninja
Copy link
Collaborator

A common confusion in the Python ecosystem is the difference between distribution names and package names. I've seen users be slightly confused by types-* and *-stubs, so it can't hurt to be more explicit

Remove mentions of ancient pip and distutils

One maybe controversial thing is the loosening of a SHOULD to a MAY. This is meant to reflect the reality of how e.g. typeshed operates, which I think is pretty well thought through and I would be opposed to changing.

A common confusion in the Python ecosystem is the difference between
distribution names and package names. I've seen users be slightly
confused by types-* and *-stubs, so it can't hurt to be more explicit

Remove mentions of ancient pip and distutils

One maybe controversial thing is the loosening of a SHOULD to a MAY.
This is meant to reflect the reality of how e.g. typeshed operates,
which I think is pretty well thought through and I would be opposed to
changing.
docs/spec/distributing.rst Outdated Show resolved Hide resolved
docs/spec/distributing.rst Outdated Show resolved Hide resolved
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but i agree with Sebastian's comments.

@hauntsaninja hauntsaninja requested a review from srittau January 14, 2024 02:04
@hauntsaninja hauntsaninja merged commit 4b7d0b7 into python:main Jan 14, 2024
3 checks passed
@hauntsaninja hauntsaninja deleted the distrib branch January 14, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants