Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added language to reflect the intended behavior for triple-quoted type annotation expressions. #1578

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Added language to reflect the intended behavior for triple-quoted type annotation expressions. #1578

merged 2 commits into from
Jan 15, 2024

Conversation

erictraut
Copy link
Collaborator

This is related to this discussion.

@erictraut erictraut mentioned this pull request Jan 13, 2024
Closed
5 tasks
@gvanrossum
Copy link
Member

LGTM now.

(OT: We should have a workflow to preview the Sphinx-generated HTML, as we have for CPython.)

@srittau srittau closed this Jan 14, 2024
@srittau srittau reopened this Jan 14, 2024
@gvanrossum
Copy link
Member

Preview here looks good.

@hauntsaninja
Copy link
Collaborator

Linking python/typing-council#9

rchen152
rchen152 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@rchen152 rchen152 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change.

@erictraut
Copy link
Collaborator Author

@rchen152, if that looks good to you, can you sign off on the TC issue here. Thanks!

@rchen152
Copy link
Collaborator

@rchen152, if that looks good to you, can you sign off on the TC issue here. Thanks!

Ah, I didn't realize that that was what the checkboxes were for. Done!

gvanrossum
gvanrossum approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but try not to force push (I have no idea if you made a subtle change since the last commit).

@erictraut erictraut merged commit 0665b39 into python:main Jan 15, 2024
4 checks passed
@erictraut erictraut deleted the triple_quote branch January 15, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau left review comments

@rchen152 rchen152 rchen152 approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erictraut @gvanrossum @hauntsaninja @rchen152 @srittau