Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List pip as an explicit dependency for the conformance tests #1757

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

AlexWaygood
Copy link
Member

I created a virtual environment using uv, which meant that pip wasn't automatically installed into my environment, causing all tests to be skipped due to things like this:

try:
run(
[sys.executable, "-m", "pip", "install", "mypy", "--upgrade"],
check=True,
)
return True
except CalledProcessError:
print("Unable to install mypy")
return False

I created a virtual environment using `uv`, which meant that `pip` wasn't automatically installed into my environment, causing all tests to be skipped due to things like this:

https://github.com/python/typing/blob/a79b87fadb0185d8032211dc81638f4acb5bc122/conformance/src/type_checker.py#L76-L84
@erictraut erictraut merged commit d442dcb into main Jun 2, 2024
6 checks passed
@erictraut erictraut deleted the AlexWaygood-patch-1 branch June 2, 2024 16:59
carljm added a commit to carljm/typing that referenced this pull request Jun 12, 2024
* main:
  Adds links to Python Discourse and ruff to typing.readthedocs.io (python#1774)
  Conformance tests: Mark pytype as passing annotations_coroutines (python#1771)
  Conformance tests: Fix manual scoring discrepancy for pyre (python#1770)
  Updated conformance test results for pyright 1.1.366. (python#1768)
  Spec: "Distributing type information": add links to PEPs 484 and 561; add a new anchor for easy intersphinx referencing (python#1767)
  Implemented conformance tests for Enums chapter. (python#1764)
  Fixed two bugs in the conformance test: (python#1763)
  Fixed two small typos in Enums chapter that I discovered when writing… (python#1762)
  Typo fix: Replace `TypeVar` with `TypeVarTuple` in a docs example (python#1760)
  Added draft chapter to typing spec for enumerations. (python#1759)
  List pip as an explicit dependency for the conformance tests (python#1757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants