Implemented conformance tests for Enums chapter. #1764
Conversation
|
Most of these tests are direct copies of the sample code in the spec. The only part that was a little tricky is that many of the type checker behaviors in the Enums chapter are optional, so many of the error conditions needed to be marked as |
…ecific asert_type behavior.
… enum_tests # Conflicts: # conformance/results/pyright/enums_expansion.toml # conformance/tests/enums_expansion.py
|
The following commit authors need to sign the Contributor License Agreement:
Click the button to sign: |
|
@srittau, there appears to be a general problem with the pre-commit bot. The "CLA signing" rule thinks that it is a human who hasn't signed the CLA. Any thoughts on how we can fix this? |
|
I guess that's a bug in the bot, cc @ambv. It should ignore the pre-commit bot's email address somehow. We probably haven't run into this before because the main other repo where we use the bot is CPython, which doesn't use pre-commit autofixers. I'm an admin on this repo and I can merge through the CLA bot failure, so I'll merge this (after I've reviewed it, which might take some time). |
|
@JelleZijlstra, thanks for the review. I incorporated changes based on your suggestions. I'm not able to override the "CLA Signing" rule, so I can't merge this. If/when you feel it's ready, please merge. |
|
I wouldn't call it a CLA bot bug, it's just missing configuration regarding this particular bot. We have plenty pre-allowed ones for cpython specifically. |
* main: Adds links to Python Discourse and ruff to typing.readthedocs.io (python#1774) Conformance tests: Mark pytype as passing annotations_coroutines (python#1771) Conformance tests: Fix manual scoring discrepancy for pyre (python#1770) Updated conformance test results for pyright 1.1.366. (python#1768) Spec: "Distributing type information": add links to PEPs 484 and 561; add a new anchor for easy intersphinx referencing (python#1767) Implemented conformance tests for Enums chapter. (python#1764) Fixed two bugs in the conformance test: (python#1763) Fixed two small typos in Enums chapter that I discovered when writing… (python#1762) Typo fix: Replace `TypeVar` with `TypeVarTuple` in a docs example (python#1760) Added draft chapter to typing spec for enumerations. (python#1759) List pip as an explicit dependency for the conformance tests (python#1757)
No description provided.