Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move best practices out of "Type Stubs" doc into guide on writing stubs. #1817

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Move best practices out of "Type Stubs" doc into guide on writing stubs. #1817

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5ff14f1
Move best practices out of "Type Stubs" doc into guide on writing stubs.
rchen152 Jul 24, 2024
cfc7150
Add missing label.
rchen152 Jul 24, 2024
1daad10
Another missing label.
rchen152 Jul 24, 2024
2e75d36
Improve suggested annotation.
rchen152 Jul 25, 2024
f4e47f0
Fix Protocol name.
rchen152 Jul 25, 2024
eb91f7b
Consolidate advice on stub-only objects and make it more consistent.
rchen152 Jul 25, 2024
7385a67
Remove recommendation to add `# incomplete` comment.
rchen152 Jul 25, 2024
ca82277
Grammar fix.
rchen152 Jul 25, 2024
0221a12
Typo fix
rchen152 Jul 26, 2024
17cd909
Better example of when to include all possible elements in __all__
rchen152 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading