Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypedDict: clarify that a non-ReadOnly key cannot be redeclared as ReadOnly. #1859

Merged
merged 1 commit into from
Sep 27, 2024
Merged

TypedDict: clarify that a non-ReadOnly key cannot be redeclared as ReadOnly. #1859

merged 1 commit into from
Sep 27, 2024

Conversation

rchen152
Copy link
Collaborator

This is covered in the conformance tests (

typing/conformance/tests/typeddicts_readonly_consistency.py

Line 38 in d93fba9

v4: B1 = c # E
and

typing/conformance/tests/typeddicts_readonly_consistency.py

Line 81 in d93fba9

v3: B2 = a # E
) but not explicitly stated in the spec.

@rchen152 rchen152 mentioned this pull request Sep 27, 2024
Closed
5 tasks
@carljm carljm merged commit 0f38667 into python:main Sep 27, 2024
5 checks passed
@rchen152 rchen152 deleted the typeddict branch September 28, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@sobolevn sobolevn sobolevn approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@carljm carljm carljm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rchen152 @carljm @JelleZijlstra @sobolevn @hauntsaninja