Fix the type signature of collision check methods. #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type of the sprites in the result never depend on the first argument single sprite. Instead, it depends on the type of sprites in the given `sprite_list`. Previously, some signatures did not accurately reflect those properties. This commit fixes them. Fixes pythonarcade#2576.
pushfoo
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
I'm in favor of merging since:
- The
SpriteListis more crucial than the physics engines - The physics engine annotations are sort of kludgy
- Completely overhaul Arcade's physics engines, and physics engine dependencies. #2580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of the sprites in the result never depend on the first argument single sprite. Instead, it depends on the type of sprites in the given
sprite_list.Previously, some signatures did not accurately reflect those properties. This commit fixes them.
Fixes #2576.
I don't think this can be tested per se? The tests don't seem to be checked by mypy, are they?
FWIW, changing
sprite_list: SpriteListtoSpriteList[BasicSprite](only) did report type errors insidecheck_collision_with_sprite_list. It previously passed the type checker only because it was inferred asSpriteList[Unknown], which it was happy to assign toIterable[SpriteType].