Raise TypeError if Viewport is not a Rect and make Viewport #2790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge makes
viewporta property of Camera2D and adds a setter for it. In the setter, and in init, we check thatviewportis aRectand raise aTypeErrorif it is not.Without this check, an error will be raised after either calling
Camera2D.equalise()or inCamera2D.use(), which may confuse users as to why the error is occurring.Backtrace when calling
Camera2D.equalise()with a non-rect viewport:Backtrace when calling
Camera2D.use()with a non-rect viewport: