Armour #13
Armour #13
Conversation
src/fantasy_forge/shell.py
Outdated
| """shows the players armour""" | ||
| for armour_type, armour_item in self.player.armour_slots.items(): | ||
| if armour_item is None: | ||
| print(f"{armour_type}: None") |
There was a problem hiding this comment.
Can an armor type be None? If it can we should add a translated message for it, if not, it should be a warning through a logger. If it can't be none we could add a check #16 for it.
If we didn't care about this stuff until now it shouldn't block the PR but it doesn't hurt to keep good old issue #16 around
data/l10n/en/main.ftl
Outdated
| @@ -14,6 +14,7 @@ item-is-in-inventory = You already picked up this item. | |||
| pick-up-failed-message = You can't pick up this item. | |||
| go-failed-message = You can't go there. | |||
| equip-item-message = You equipped { INTER($item) }. | |||
| unequip-item-message = You took of { INTER(§item)} and took it in your inventory. | |||
There was a problem hiding this comment.
So if you wear the armour or an item in general it takes up space in your inventory, right? So you can't over-equip. Otherwise it could not work to add it to the inventory.
Somehow I don't know if I am happy about this. Imagine a pretty efficient plate-like armour. It would be heavy and take up more space in your inventory, right? If you would carry a heavy weapon too, and you can have different types of armour, the inventory has to be huge or you can't carry much else. Or, and simpler is often better, an armour could be a fixed amount of slots regardless of effectiveness.
|
So what is missing from this is the whole unequip flow and substracting defence points, right? Looks fine :) good job :) |
Implements an Armour class for things like clothing, hats etc. The Player has certain armour slots which can only hold one armour item at the same time. Armour items can be equiped just like weapons. The defense values of each armour piece is summed up in the Player.defense property.