Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX #22] Added blog integration #35

Closed
wants to merge 3 commits into from
Closed

[FIX #22] Added blog integration #35

wants to merge 3 commits into from

Conversation

amitsin6h
Copy link
Contributor

Reading rss from https://in.pycon.org/blog/feeds/all.atom.xml was not possible due to Cross domain that's why I used crossorigin.me so that I can successfully get the xml from the source. As I was on the localhost and reading xml from the source was not possible and reason I used crossorigin.me. For now I have commented out most of the code so that It can be understood. So now we can see the feed parsing from the source is working. I will be uploading my second patch after following the pythonic way :p. Please review and let me know. Issue #22 can be closed now.

@realslimshanky
Copy link
Member

realslimshanky commented Jul 13, 2017

Hi @amitsin6h , you're trying to rebuild the entire blog. We already have one here. Also, all the issues regarding the feed and/or the PyCon Blog should be issued here.
'display first few post' which was mentioned on the issue #22, this might be done on the homepage itself like twitter feed. Making another page just for the blog is redundant as we already have a blog.

@amitsin6h
Copy link
Contributor Author

@realslimshanky no blog post has been made for 2017 that's the reason i cannot fetch the blog. and I used the old blog feed link but thats not the problem we can chnage the feed link anytime when our 2017 blog feed is ready. I dont get from where we should fetch 'first few post' which feed link are you talking about.

@amitsin6h
Copy link
Contributor Author

@CuriousLearner am fetching blog from the feed link. Is their something wrong please let me know

@amitsin6h
Copy link
Contributor Author

@realslimshanky in which page we should show the blog post and how many blog post we are supposed to show.

Copy link
Member

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitsin6h how is twitterfetch related to blog integration?

@amitsin6h amitsin6h closed this Jul 18, 2017
thisisayush added a commit to thisisayush/inpycon2017 that referenced this pull request Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants