Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move CI to Github Actions #692

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

palnabarun
Copy link
Member

Travis CI is occasionally missing events from GitHub and hence becoming
very flaky to use, for example, in #682 and #689, the events are not being
detected at all.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f866be3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #692   +/-   ##
=========================================
  Coverage          ?   66.78%           
=========================================
  Files             ?       50           
  Lines             ?     1993           
  Branches          ?        0           
=========================================
  Hits              ?     1331           
  Misses            ?      662           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f866be3...9af2371. Read the comment docs.

@palnabarun palnabarun force-pushed the add-github-actions branch from 843fe55 to 9af2371 Compare June 7, 2020 13:41
@@ -20,7 +20,7 @@ jobs:
include:
# Basic Checks
- stage: primary
env: NOXSESSION=lint-3.5
env: NOXSESSION=lint-3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe take out this change since we are planning to move away from Travis ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is why the PR is labelled WIP. It is still functionally incomplete.

run: |
pip install --upgrade pip
pip install nox
pip install coveralls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be required here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. 👍

@ananyo2012
Copy link
Contributor

ananyo2012 commented Jun 7, 2020

@palnabarun Does github CI doesn't have the concept of sessions/env ? I see you had to setup 2 separate workflow files.

Also coveralls report still doesn't seem to be coming.
I see coverage is reported by codecov instead of coveralls, which is fine. But it is messing up with the coverage report. Instead of providing coverage reports per session it is overwriting the report each time.

Also test-3.6 and test-3.8 is being skipped due to missing interpreters

@palnabarun
Copy link
Member Author

Does github CI doesn't have the concept of sessions/env ?

I didn't get you.

I see you had to setup 2 separate workflow files.

They are for different things. There is less clarity on how workflows should be structured, but functionally separating things seems to be the right way.

@palnabarun
Copy link
Member Author

I see coverage is reported by codecov instead of coveralls, which is fine. But it is messing up with the coverage report. Instead of providing coverage reports per session it is overwriting the report each time.

These things are being worked out and that is why the PR is WIP.

Also test-3.6 and test-3.8 is being skipped due to missing interpreters

Yes. Again this is WIP. There are issues with nox detecting the right environments. If I need to install all Python versions when using nox, it completely defeats the purpose. Since, I can elegantly use matrix in Github Actions, each individual version of Python can be setup separately. When I did that, nox broke when Python 2.7 was the interpreter. I am working to resolve the issues.

@ananyo2012 ananyo2012 changed the title Move CI to Github Actions [WIP] Move CI to Github Actions Jun 7, 2020
@ananyo2012
Copy link
Contributor

Sorry I missed the WIP label and went ahead and reviewd. More used to see WIP in title 😛

@ananyo2012
Copy link
Contributor

Does github CI doesn't have the concept of sessions/env ?

I didn't get you.

I see you had to setup 2 separate workflow files.

They are for different things. There is less clarity on how workflows should be structured, but functionally separating things seems to be the right way.

Yes indeed. Maybe GitHub CI doesn't support nox session like Travis does. Both the workflows has a lot of duplicate setup. Would be nice if there was some base setup from which things could be derived.

@palnabarun
Copy link
Member Author

Sorry I missed the WIP label and went ahead and reviewd. More used to see WIP in title stuck_out_tongue

Ah. No problem.

@pradyunsg
Copy link
Contributor

For Travis CI, the fix/workaround for the flakiness is to install their GitHub App, instead of using a webhook.

OTOH, GitHub Actions is enough of an improvement in compute capacity, to justify switching IMO -- they give more "workers" per repo (20 + 5 MacOS), and their vCPUs are clocked higher (AFAIK).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants