Support for urls without http/s #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SurajJadhav7
force-pushed
the
url-valid
branch
from
7e6a69a
to
fdf62ef
Compare
SurajJadhav7
force-pushed
the
url-valid
branch
from
fdf62ef
to
37e5590
Compare
amolkahat
requested changes
Jan 21, 2021
| validate_code = validate_url.status_code | ||
| if url.startswith(("http://", "https://")): | ||
| validate_code = requests.get(url).status_code | ||
| elif requests.get("http://" + url).status_code == 200: |
There was a problem hiding this comment.
Above 2 line code is sufficient. Don't need this.
| validate_code = validate_url.status_code | ||
| if url.startswith(("http://", "https://")): | ||
| validate_code = requests.get(url).status_code | ||
| elif requests.get("http://" + url).status_code == 200: |
| validate_code = validate_url.status_code | ||
| if url.startswith(("http://", "https://")): | ||
| validate_code = requests.get(url).status_code | ||
| elif requests.get("http://" + url).status_code == 200: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #155
User will be able to add urls without url scheme (http/s).
Support for urls with ftp, mailto, telnet is not added yet.