Plugin for GitHub #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ganeshhubale <[email protected]>
|
@ganeshhubale the #13 was solved already by PR #21, I forgot to close that issue. The issue your PR fixes is different, can you please create a new issue mentioning details of the bug your PR solves? |
|
I have created new issue #30 |
akshay196
requested changes
Aug 29, 2018
plugins/github.py
Outdated
| github_url = "https://api.github.com" | ||
| r = requests.get(os.path.join(github_url, "repos", username, repository, "pulls")) | ||
| r = requests.get(os.path.join(github_url, "repos", repository, "pulls")) | ||
| js = json.loads(r.content) | ||
| for i in range(0, len(js)): |
There was a problem hiding this comment.
Here js is a list. We can iterate over items in a list without range(). Then this for loop would be:
for pull in js:
if username == pull['user']['login']:
if 'title' in pull.keys():
list_of_pull_requests.append(pull['title'])
Signed-off-by: ganeshhubale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #13
Signed-off-by: ganeshhubale [email protected]