Avoid repeat error reports #218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an op depends on two nodes that are failing at the time it is issued, then history will generate two failure messages for the sequence number. If there was a future attached to the sequence number, then the second failre will cause a KeyError in the invocation dicationary since the first instance already removed it. This depends on a race condition to hit because the messages for the failure must already be present when the node failing is being added. Differential Revision: [D76372510](https://our.internmc.facebook.com/intern/diff/D76372510/) [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
This was referenced Jun 10, 2025
|
This pull request was exported from Phabricator. Differential Revision: D76372510 |
mariusae
pushed a commit
to mariusae/monarch-1
that referenced
this pull request
Jun 10, 2025
Summary: If an op depends on two nodes that are failing at the time it is issued, then history will generate two failure messages for the sequence number. If there was a future attached to the sequence number, then the second failre will cause a KeyError in the invocation dicationary since the first instance already removed it. This depends on a race condition to hit because the messages for the failure must already be present when the node failing is being added. ghstack-source-id: 289532983 exported-using-ghexport Reviewed By: suo Differential Revision: D76372510
|
This pull request has been merged in 2432c26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
If an op depends on two nodes that are failing at the time it is issued, then history will generate two failure messages for the sequence number. If there was a future attached to the sequence number, then the second failre will cause a KeyError in the invocation dicationary since the first instance already removed it.
This depends on a race condition to hit because the messages for the failure must already be present when the node failing is being added.
Differential Revision: D76372510