subscription response #293
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D76343950
Differential Revision: D76821366
Differential Revision: D76822966
Summary: This diff enhanced the `Subscribe` and `Unsubscribe` messages with a returned result. Indicating if the operation is successful or not. Two cases will return error for now 1. subscribing a already subscribed client 2. unsubscribing a non-existing client In order to get the return message, we have to add the client address to the address book. That's why a new message `Join` is added. Similar to the old `SystemActor` (https://fburl.com/code/tl74i2sn). Differential Revision: D76838123
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76838123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff enhanced the
SubscribeandUnsubscribemessages with a returned result. Indicating if the operation is successful or not.Two cases will return error for now
In order to get the return message, we have to add the client address to the address book. That's why a new message
Joinis added. Similar to the oldSystemActor(https://fburl.com/code/tl74i2sn).Differential Revision: D76838123