(2/n torchx-allocator)(monarch/tools) implement a way to resolve hostname to ipv6 or ipv4 address #295
+122
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76846286 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…name to ipv6 or ipv4 address (#295) Summary: implement `monarch.tools.network.get_ip_addr(hostname)` that resolves a hostname to an ip address by: 1. Look up a TCP (`SOCK_STREAM`) compatible ipv6 address 2. If not found, fall-back to TCP compatible ipv4 address 3. Error if no ipv6 or ipv4 This is required since hyperactor's `ChannelAddr` for the `tcp` transport (e.g. `tcp!slurm-compute-node-0:26600`) takes a socketaddr (ip + port) not a hostname. So the caller has to resolve the hostname (typically queried from the scheduler) to an ip. Reviewed By: ahmadsharif1 Differential Revision: D76846286
…name to ipv6 or ipv4 address (#295) Summary: implement `monarch.tools.network.get_ip_addr(hostname)` that resolves a hostname to an ip address by: 1. Look up a TCP (`SOCK_STREAM`) compatible ipv6 address 2. If not found, fall-back to TCP compatible ipv4 address 3. Error if no ipv6 or ipv4 This is required since hyperactor's `ChannelAddr` for the `tcp` transport (e.g. `tcp!slurm-compute-node-0:26600`) takes a socketaddr (ip + port) not a hostname. So the caller has to resolve the hostname (typically queried from the scheduler) to an ip. Reviewed By: ahmadsharif1 Differential Revision: D76846286
facebook-github-bot
force-pushed
the
export-D76846286
branch
from
3a0d0ad to
d11b4d7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76846286 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…name to ipv6 or ipv4 address (#295) Summary: implement `monarch.tools.network.get_ip_addr(hostname)` that resolves a hostname to an ip address by: 1. Look up a TCP (`SOCK_STREAM`) compatible ipv6 address 2. If not found, fall-back to TCP compatible ipv4 address 3. Error if no ipv6 or ipv4 This is required since hyperactor's `ChannelAddr` for the `tcp` transport (e.g. `tcp!slurm-compute-node-0:26600`) takes a socketaddr (ip + port) not a hostname. So the caller has to resolve the hostname (typically queried from the scheduler) to an ip. Reviewed By: ahmadsharif1 Differential Revision: D76846286
|
This pull request has been merged in c14038c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
implement
monarch.tools.network.get_ip_addr(hostname)that resolves a hostname to an ip address by:SOCK_STREAM) compatible ipv6 addressThis is required since hyperactor's
ChannelAddrfor thetcptransport (e.g.tcp!slurm-compute-node-0:26600) takes a socketaddr (ip + port) not a hostname. So the caller has to resolve the hostname (typically queried from the scheduler) to an ip.Differential Revision: D76846286