Add schema compatibility test #3130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D61766648 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
spcyppt
force-pushed
the
export-D61766648
branch
from
c64b706
to
ce6ffbb
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 17, 2024
Summary: X-link: facebookresearch/FBGEMM#217 To ensure that changes to the ops are forward and backward compatible with the stable release, we add unit tests to test schema compatibility. **Usage**: ``` check_schema_compatibility_from_op_name( namespace: Callable, op_name: str ref_schema_str: str, ) check_schema_compatibility( op: Callable, ref_schema_str: str, ) ``` e.g., ``` check_schema_compatibility_from_op_name( torch.ops.fbgemm, "merge_pooled_embeddings", "fbgemm::merge_pooled_embeddings(Tensor[] pooled_embeddings, SymInt uncat_dim_size, Device target_device, SymInt cat_dim=1) -> Tensor" ) check_schema_compatibility( fbgemm_gpu.sparse_ops.merge_pooled_embeddings, "merge_pooled_embeddings(Tensor[] pooled_embeddings, int uncat_dim_size, Device target_device, int cat_dim=1) -> Tensor", ) ``` Differential Revision: D61766648
|
This pull request was exported from Phabricator. Differential Revision: D61766648 |
Summary: X-link: facebookresearch/FBGEMM#217 To ensure that changes to the ops are forward and backward compatible with the stable release, we add unit tests to test schema compatibility. **Usage**: ``` check_schema_compatibility_from_op_name( namespace: Callable, op_name: str ref_schema_str: str, ) check_schema_compatibility( op: Callable, ref_schema_str: str, ) ``` e.g., ``` check_schema_compatibility_from_op_name( torch.ops.fbgemm, "merge_pooled_embeddings", "fbgemm::merge_pooled_embeddings(Tensor[] pooled_embeddings, SymInt uncat_dim_size, Device target_device, SymInt cat_dim=1) -> Tensor" ) check_schema_compatibility( fbgemm_gpu.sparse_ops.merge_pooled_embeddings, "merge_pooled_embeddings(Tensor[] pooled_embeddings, int uncat_dim_size, Device target_device, int cat_dim=1) -> Tensor", ) ``` Differential Revision: D61766648
spcyppt
force-pushed
the
export-D61766648
branch
from
ce6ffbb
to
8beab8d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61766648 |
|
This pull request has been merged in 0377308. |
spcyppt
added a commit
that referenced
this pull request
Oct 7, 2024
Summary: X-link: facebookresearch/FBGEMM#217 Pull Request resolved: #3130 To ensure that changes to the ops are forward and backward compatible with the stable release, we add unit tests to test schema compatibility. **Usage**: ``` check_schema_compatibility_from_op_name( namespace: Callable, op_name: str ref_schema_str: str, ) check_schema_compatibility( op: Callable, ref_schema_str: str, ) ``` e.g., ``` check_schema_compatibility_from_op_name( torch.ops.fbgemm, "merge_pooled_embeddings", "fbgemm::merge_pooled_embeddings(Tensor[] pooled_embeddings, SymInt uncat_dim_size, Device target_device, SymInt cat_dim=1) -> Tensor" ) check_schema_compatibility( fbgemm_gpu.sparse_ops.merge_pooled_embeddings, "merge_pooled_embeddings(Tensor[] pooled_embeddings, int uncat_dim_size, Device target_device, int cat_dim=1) -> Tensor", ) ``` Reviewed By: q10 Differential Revision: D61766648 fbshipit-source-id: dac52b88834331a466e7165812def1a3fe4c0804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To ensure that changes to the ops are forward and backward compatible with the stable release, we add unit tests to test schema compatibility.
Usage:
e.g.,
Differential Revision: D61766648