Allow bounds_check_mode to be set by environment variable #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D63549883 |
|
This pull request was exported from Phabricator. Differential Revision: D63549883 |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: pytorch#3187 X-link: facebookresearch/FBGEMM#282 This very simple diff allows TBE's bounds_check_mode to be overwritten by the environment variable `FBGEMM_TBE_BOUNDS_CHECK_MODE`. When set to `3`, this will disable bounds checking. Reviewed By: qchip Differential Revision: D63549883
jwfromm
force-pushed
the
export-D63549883
branch
from
9f2fbec to
d3b0d8d
Compare
Summary: Pull Request resolved: pytorch#3187 X-link: facebookresearch/FBGEMM#282 This very simple diff allows TBE's bounds_check_mode to be overwritten by the environment variable `FBGEMM_TBE_BOUNDS_CHECK_MODE`. When set to `3`, this will disable bounds checking. Reviewed By: renganxu, qchip Differential Revision: D63549883
|
This pull request was exported from Phabricator. Differential Revision: D63549883 |
jwfromm
force-pushed
the
export-D63549883
branch
from
d3b0d8d to
189c0dd
Compare
|
This pull request has been merged in 5582d23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/282
This very simple diff allows TBE's bounds_check_mode to be overwritten by the environment variable
FBGEMM_TBE_BOUNDS_CHECK_MODE. When set to3, this will disable bounds checking.Reviewed By: qchip
Differential Revision: D63549883