Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for int32_t indices in TBE training (2D/N) #3374

Closed
wants to merge 2 commits into from
Closed

Add support for int32_t indices in TBE training (2D/N) #3374

wants to merge 2 commits into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Nov 14, 2024

Summary: - Add index_t support to TBE training backward kernels

Differential Revision: D65930273

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65930273

@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 7546511
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/6781a054ce323d0008147994
😎 Deploy Preview https://deploy-preview-3374--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
e831b65 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
6dda561 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
20e6c9a 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
4932c9d 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
03206b3 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
4cef12a 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
2d3e048 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
@q10 q10 force-pushed the export-D65930273 branch from 054740b to 2d3e048 Compare December 14, 2024 22:29
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
9e3c3f4 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
@q10 q10 force-pushed the export-D65930273 branch from 2d3e048 to 9e3c3f4 Compare December 14, 2024 22:29
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65930273

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65930273

q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
fcb9e74 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
c4df88d 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
e3ce57d 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
019dc22 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
@facebook-github-bot
Copy link
Contributor

Hi @q10!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@q10 q10 force-pushed the export-D65930273 branch from 9e3c3f4 to 3726e16 Compare January 2, 2025 20:36
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
3726e16 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65930273

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
75f9af9 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
0535a6c 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
8e5118f 
Summary:
X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 3, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
7b184f3 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 3, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
617a434 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
@q10 q10 force-pushed the export-D65930273 branch from 3726e16 to 2bc3b1c Compare January 6, 2025 21:41
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
76c505a 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
4077187 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
3dec085 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
517c66c 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 7, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
2e15d3b 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 7, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
7be1fb5 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
d1078b6 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65930273
@q10 q10 force-pushed the export-D65930273 branch from e3e3cf9 to 393415d Compare January 9, 2025 22:20
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
393415d 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
8174858 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65930273

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
b2391e0 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
0aced99 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
a75e44d 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
b2c4900 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
q10 added 2 commits January 10, 2025 14:33
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
33519b9 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65925354
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
7546511 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
@q10 q10 force-pushed the export-D65930273 branch from 393415d to 7546511 Compare January 10, 2025 22:33
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
41b39c4 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65930273

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
0b15040 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
754ebd1 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
cb03abf 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
177d8ac 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 11, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
b42d9e2 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 11, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
8e269fb 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a93eed4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q10 @facebook-github-bot