Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for int32_t indices in TBE training (2G/N) #3377

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add support for int32_t indices in TBE training (2G/N) #3377

wants to merge 5 commits into from
+77 −50

Conversation

q10
Copy link
Contributor

@q10 q10 commented Nov 14, 2024

Summary: - Add index_t support to TBE training backward kernels

Differential Revision: D65960050

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65960050

@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 33bc751
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/67804bf3e97a5b0008876821
😎 Deploy Preview https://deploy-preview-3377--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@q10 q10 force-pushed the export-D65960050 branch from 5a012a1 to 569c1a3 Compare December 14, 2024 22:29
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65960050

@q10 q10 force-pushed the export-D65960050 branch from 569c1a3 to 6c41ce6 Compare December 14, 2024 22:30
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65960050

q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
a1ae677 
Summary:

X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
@facebook-github-bot
Copy link
Contributor

Hi @q10!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@q10 q10 force-pushed the export-D65960050 branch from 6c41ce6 to 00bb1db Compare January 2, 2025 20:37
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
00bb1db 
Summary:

X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65960050

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
ea2d531 
Summary:

X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 3, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
f417db8 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 3, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
4f405e9 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
c19b9b8 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
@q10 q10 force-pushed the export-D65960050 branch from 00bb1db to 0eebd00 Compare January 6, 2025 21:42
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
0eebd00 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65960050

@q10 q10 force-pushed the export-D65960050 branch from 0eebd00 to 14b3b97 Compare January 6, 2025 21:43
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
14b3b97 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65960050

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
683c5c5 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
2681116 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
a65d68a 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 7, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
05561c9 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 7, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
1573d07 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
4890206 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65960050
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2B/N) (pytorch#3371)
81ed5d9 
Summary:
X-link: facebookresearch/FBGEMM#618


X-link: facebookresearch/FBGEMM#462

- Fix `hash_size_cumsum` to be `int64_t` in `linearize_index_index_select_kernel` and `linearize_index_kernel`
- Enable more specializations for radix sort

Reviewed By: r-barnes

Differential Revision: D65923591
q10 added 4 commits January 9, 2025 14:20
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
6a8b388 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65925354
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2D/N) (pytorch#3374)
b2391e0 
Summary:
X-link: facebookresearch/FBGEMM#620

X-link: facebookresearch/FBGEMM#464


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65930273
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2E/N) (pytorch#3375)
12b7b1c 
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
33bc751 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65960050
@q10 q10 force-pushed the export-D65960050 branch from 14b3b97 to 33bc751 Compare January 9, 2025 22:21
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65960050

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
2a7633e 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65960050
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
bac1b7d 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65960050
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2G/N) (pytorch#3377)
052f07e 
Summary:
X-link: facebookresearch/FBGEMM#622


X-link: facebookresearch/FBGEMM#468

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65960050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q10 @facebook-github-bot