Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fbgemm_gpu] Fix versioning scheme for ROCm releases #3554

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/utils_pip.bash
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ __export_package_variant_info () {
# e.g. rocm 6.2.4 => rocm6.2.4
#
# NOTE: Unlike CUDA-based releases, which ignores the minor patch version,
# ROCm-based releases use the full version string.
# ROCm-based releases may use the full version string.
# See https://download.pytorch.org/whl/nightly/torch/ for examples.
local variant_type="rocm"
if [ "${rocm_version_arr[2]}" == "" ]; then
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/fbgemm_gpu_pip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ jobs:
]
# ROCm machines are limited, so we only test a subset of Python versions
python-version: [ "3.9", "3.10", "3.11", "3.12", "3.13" ]
rocm-version: [ "6.1.2", "6.2.4" ]
rocm-version: [ "6.2.4", "6.3" ]

steps:
- name: Setup Build Container
Expand Down
10 changes: 9 additions & 1 deletion fbgemm_gpu/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,15 @@ def variant_version(self) -> str:
elif self.args.package_variant == "rocm":
if torch.version.hip is not None:
rocm_version = torch.version.hip.split(".")
pkg_vver = f"+rocm{rocm_version[0]}.{rocm_version[1]}"
# NOTE: Unlike CUDA-based releases, which ignores the minor patch version,
# ROCm-based releases may use the full version string.
# See https://download.pytorch.org/whl/nightly/torch/ for examples.
if len(rocm_version) > 2:
pkg_vver = (
f"+rocm{rocm_version[0]}.{rocm_version[1]}.{rocm_version[2]}"
)
else:
pkg_vver = f"+rocm{rocm_version[0]}.{rocm_version[1]}"
else:
sys.exit(
"[SETUP.PY] The installed PyTorch variant is not ROCm; cannot determine the ROCm version!"
Expand Down
Loading