Add support for int32_t indices in TBE training (2K/N)
#3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68296454 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 16, 2025
Summary: - Update TBE benchmark test to support `int32_t` indicies Differential Revision: D68296454
|
This pull request was exported from Phabricator. Differential Revision: D68296454 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 17, 2025
Summary: X-link: facebookresearch/FBGEMM#668 - Update TBE benchmark test to support `int32_t` indicies Reviewed By: basilwong Differential Revision: D68296454
|
This pull request was exported from Phabricator. Differential Revision: D68296454 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 21, 2025
Summary: X-link: facebookresearch/FBGEMM#668 - Update TBE benchmark test to support `int32_t` indicies Reviewed By: basilwong Differential Revision: D68296454
|
This pull request was exported from Phabricator. Differential Revision: D68296454 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 22, 2025
Summary: X-link: facebookresearch/FBGEMM#668 - Update TBE benchmark test to support `int32_t` indicies Reviewed By: basilwong Differential Revision: D68296454
|
This pull request was exported from Phabricator. Differential Revision: D68296454 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 22, 2025
Summary: X-link: facebookresearch/FBGEMM#668 Pull Request resolved: pytorch#3583 - Update TBE benchmark test to support `int32_t` indicies Reviewed By: basilwong Differential Revision: D68296454
|
This pull request was exported from Phabricator. Differential Revision: D68296454 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 23, 2025
Summary: X-link: facebookresearch/FBGEMM#668 - Update TBE benchmark test to support `int32_t` indicies Reviewed By: basilwong Differential Revision: D68296454
|
This pull request was exported from Phabricator. Differential Revision: D68296454 |
Summary: X-link: facebookresearch/FBGEMM#668 - Update TBE benchmark test to support `int32_t` indicies - Currently only supports dual int32_t indices/offsets or int64_t indices/offsets, no mixed. Depending on future feedback, we might enable mixed mode, similar to the prototype work done in D63857531. Reviewed By: basilwong Differential Revision: D68296454
|
This pull request was exported from Phabricator. Differential Revision: D68296454 |
|
This pull request has been merged in 5f3adca. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: - Update TBE benchmark test to support
int32_tindiciesDifferential Revision: D68296454