Update the rowwise adagrad optimizer to leverage optimizer state offloading, v3 #4133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D74827718 |
|
This pull request was exported from Phabricator. Differential Revision: D74827718 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
May 16, 2025
…oading, v3, backend (pytorch#4133) Summary: X-link: facebookresearch/FBGEMM#1214 This diff adds support for leveraging optimizer state offloading to make optimizer state updates, starting with the rowwise adagrad optimizer. - Add compile-time flag `kEnableOptimizerOffloading` to the table update kernel to enable handling optimizer offloading, starting with the rowwise adagrad case - Propagate the compile-time flag upwards to `embedding_backward_split_template.cu`, where it is a runtime user-supplied boolean argument Differential Revision: D74827718
|
This pull request was exported from Phabricator. Differential Revision: D74827718 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
May 16, 2025
…oading, v3, backend (pytorch#4133) Summary: Pull Request resolved: pytorch#4133 X-link: facebookresearch/FBGEMM#1214 This diff adds support for leveraging optimizer state offloading to make optimizer state updates, starting with the rowwise adagrad optimizer. - Add compile-time flag `kEnableOptimizerOffloading` to the table update kernel to enable handling optimizer offloading, starting with the rowwise adagrad case - Propagate the compile-time flag upwards to `embedding_backward_split_template.cu`, where it is a runtime user-supplied boolean argument Differential Revision: D74827718
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
May 20, 2025
…oading, v3, backend (pytorch#4133) Summary: X-link: facebookresearch/FBGEMM#1214 This diff adds support for leveraging optimizer state offloading to make optimizer state updates, starting with the rowwise adagrad optimizer. - Add compile-time flag `kEnableOptimizerOffloading` to the table update kernel to enable handling optimizer offloading, starting with the rowwise adagrad case - Propagate the compile-time flag upwards to `embedding_backward_split_template.cu`, where it is a runtime user-supplied boolean argument Differential Revision: D74827718
|
This pull request was exported from Phabricator. Differential Revision: D74827718 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
May 21, 2025
…oading, v3, backend (pytorch#4133) Summary: X-link: facebookresearch/FBGEMM#1214 This diff adds support for leveraging optimizer state offloading to make optimizer state updates, starting with the rowwise adagrad optimizer. - Add compile-time flag `kEnableOptimizerOffloading` to the table update kernel to enable handling optimizer offloading, starting with the rowwise adagrad case - Propagate the compile-time flag upwards to `embedding_backward_split_template.cu`, where it is a runtime user-supplied boolean argument Differential Revision: D74827718
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
May 21, 2025
…oading, v3, backend (pytorch#4133) Summary: X-link: facebookresearch/FBGEMM#1214 This diff adds support for leveraging optimizer state offloading to make optimizer state updates, starting with the rowwise adagrad optimizer. - Add compile-time flag `kEnableOptimizerOffloading` to the table update kernel to enable handling optimizer offloading, starting with the rowwise adagrad case - Propagate the compile-time flag upwards to `embedding_backward_split_template.cu`, where it is a runtime user-supplied boolean argument Differential Revision: D74827718
|
This pull request was exported from Phabricator. Differential Revision: D74827718 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
May 21, 2025
…oading, v3, backend (pytorch#4133) Summary: Pull Request resolved: pytorch#4133 X-link: facebookresearch/FBGEMM#1214 This diff adds support for leveraging optimizer state offloading to make optimizer state updates, starting with the rowwise adagrad optimizer. - Add compile-time flag `kEnableOptimizerOffloading` to the table update kernel to enable handling optimizer offloading, starting with the rowwise adagrad case - Propagate the compile-time flag upwards to `embedding_backward_split_template.cu`, where it is a runtime user-supplied boolean argument Differential Revision: D74827718
…oading, v3, backend (pytorch#4133) Summary: Pull Request resolved: pytorch#4133 X-link: facebookresearch/FBGEMM#1214 This diff adds support for leveraging optimizer state offloading to make optimizer state updates, starting with the rowwise adagrad optimizer. - Add compile-time flag `kEnableOptimizerOffloading` to the table update kernel to enable handling optimizer offloading, starting with the rowwise adagrad case - Propagate the compile-time flag upwards to `embedding_backward_split_template.cu`, where it is a runtime user-supplied boolean argument Differential Revision: D74827718
|
This pull request was exported from Phabricator. Differential Revision: D74827718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
if the optimizer is TBE SSD, and if the user specified it
Differential Revision: D74827718