Skip to content

chore: remove pre-cxx11 abi #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: remove pre-cxx11 abi #3473

wants to merge 3 commits into from
+130 −491

Conversation

zewenli98
Copy link
Collaborator

Description

Remove pre-cxx11 abi and have some minor fixes

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Apr 15, 2025
narendasan
narendasan reviewed Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you quickly grep for other uses of "pre_cxx11_abi"

@github-actions github-actions bot added component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: build system Issues re: Build system component: api [Python] Issues re: Python API component: api [C++] Issues re: C++ API component: evaluators Issues re: Specific op evaluators component: runtime component: partitioning labels Apr 17, 2025
@zewenli98 zewenli98 requested a review from narendasan April 28, 2025 17:47
@zewenli98 zewenli98 assigned peri044 and unassigned peri044 Apr 28, 2025
@zewenli98 zewenli98 requested a review from peri044 April 28, 2025 17:48
peri044
peri044 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. LGTM

.github/scripts/generate_binary_build_matrix.py
@@ -153,26 +151,17 @@ def initialize_globals(channel: str, build_python_only: bool) -> None:
XPU: "pytorch/manylinux2_28-builder:xpu",
# TODO: Migrate CUDA_AARCH64 image to manylinux2_28_aarch64-builder:cuda12.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this comment to manylinux2_28_aarch64-builder:cuda12.6 if that's what you're using

py/README.md
@@ -31,12 +31,9 @@ torch.jit.save(trt_ts_module, "trt_torchscript_module.ts") # save the TRT embedd

| ABI / Platform | Installation command |
| --------------------------------------- | ----------------------------------------------------------------- |
| Pre CXX11 ABI (Linux x86_64) | python3 setup.py install --use-pre-cxx11-abi |
| CXX ABI (Linux x86_64) | python3 setup.py install |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CXX11* ABI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [C++] Issues re: C++ API component: api [Python] Issues re: Python API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: lowering Issues re: The lowering / preprocessing passes component: partitioning component: runtime component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zewenli98 @narendasan @peri044 @facebook-github-bot