Skip to content

fix: fix signature mismatch issue for non-tensor input in plugin converter #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

fix: fix signature mismatch issue for non-tensor input in plugin converter #3788

merged 1 commit into from
Oct 2, 2025

Conversation

bowang007
Copy link
Collaborator

Description

This PR fixes the signature mismatch issue in plugin converter.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla meta-cla bot added the cla signed label Aug 19, 2025
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Aug 19, 2025
@github-actions github-actions bot requested a review from gs-olive August 19, 2025 23:48
@bowang007 bowang007 requested review from narendasan and peri044 and removed request for gs-olive August 19, 2025 23:48
peri044
peri044 approved these changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044
Copy link
Collaborator

peri044 commented Sep 19, 2025

Can you rebase ?

@bowang007 bowang007 force-pushed the fix_plugin_converter branch from 61a5421 to 6926996 Compare October 2, 2025 07:25
@bowang007 bowang007 merged commit 6b6bb48 into main Oct 2, 2025
93 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bowang007 @peri044