cpu memory optimization rebased to main #3868
Open
+248
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
github-actions
bot
added
the
documentation
cehongwang
force-pushed
the
cpu-memory-optimization-rebase-main
branch
from
b9b6aeb to
51f64f0
Compare
narendasan
reviewed
Oct 29, 2025
narendasan
reviewed
Oct 29, 2025
|
|
||
| @needs_refit # type: ignore[misc] | ||
| def _insert_engine_to_cache(self, hash_val: str, serialized_engine: bytes) -> None: | ||
| def _insert_engine_to_cache(self, hash_val: str, engine: trt.ICudaEngine) -> None: |
There was a problem hiding this comment.
@zewenli98 when do these calls run? will this conflict with the goal of keeping mem usage under 3x?
There was a problem hiding this comment.
should we do caching in a post processing step?
There was a problem hiding this comment.
Like we can give the cache entry as one of the Interpreter Result fields
py/torch_tensorrt/dynamo/partitioning/_adjacency_partitioner.py
Outdated
Show resolved
Hide resolved
narendasan
reviewed
Oct 30, 2025
| settings: CompilationSettings = CompilationSettings(), | ||
| arg_inputs: Optional[Sequence[Input]] = None, | ||
| kwarg_inputs: Optional[dict[str, Any]] = None, | ||
| engine_cache: Optional[BaseEngineCache] = None, |
There was a problem hiding this comment.
We need to move the cache insert here
cehongwang
force-pushed
the
cpu-memory-optimization-rebase-main
branch
from
51f64f0 to
f77df5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: