Skip to content

refactor: Update Wanda for better readability #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: Update Wanda for better readability #2538

wants to merge 2 commits into from

Conversation

namgyu-youn
Copy link
Contributor

@namgyu-youn namgyu-youn commented Jul 13, 2025 •
edited
Loading

  • For helping understanding Wanda (‎torchao/sparsity/wanda.py) concepts, annotations are updated.
  • Fix PEP585 (type-check) in Ruff and minor typo

References

@namgyu-youn
fix typo
b8d2a6d 
semi_structured_bock_size → semi_structured_block_size
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2538

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2025
@namgyu-youn namgyu-youn changed the title fix typo fix typo in wanda.py Jul 18, 2025
@namgyu-youn
Copy link
Contributor Author

@pytorchbot label "sparsity" "topic: not user facing"

@pytorch-bot pytorch-bot bot added sparsity topic: not user facing Use this tag if you don't want this PR to show up in release notes labels Jul 21, 2025
@namgyu-youn namgyu-youn marked this pull request as draft July 22, 2025 05:36
@namgyu-youn namgyu-youn marked this pull request as ready for review July 22, 2025 06:07
@namgyu-youn namgyu-youn changed the title fix typo in wanda.py Update annotation in Wanda for better readability Jul 22, 2025
@namgyu-youn namgyu-youn changed the title Update annotation in Wanda for better readability refactor: Update annotation in Wanda for better readability Jul 22, 2025
@namgyu-youn namgyu-youn changed the title refactor: Update annotation in Wanda for better readability refactor: Update Wanda for better readability Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. sparsity topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namgyu-youn @facebook-github-bot