Skip to content

Mocking Librosa in tests #4010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Mocking Librosa in tests #4010

wants to merge 12 commits into from

Conversation

samanklesaria
Copy link
Collaborator

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.

@samanklesaria samanklesaria requested a review from a team as a code owner August 1, 2025 16:42
Copy link

pytorch-bot bot commented Aug 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4010

Note: Links to docs will display an error until the docs builds have been completed.

❌ 19 New Failures

As of commit 62f940f with merge base 6519052 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 1, 2025
@samanklesaria samanklesaria changed the title Mocking Mocking Librosa in tests Aug 1, 2025
@samanklesaria
Copy link
Collaborator Author

Strangely, torchaudio_unittest/transforms/librosa_compatibility_cpu_test.py passes just fine on my machine. But a difference of 0.007 between the cached librosa value and the torchaudio computed value is quite large.

Perhaps this is a versioning thing? I have librosa 0.11.0 and numpy 2.1.2.

I think the next step is to ensure that my changing the numpy version during testing didn't break anything by always comparing with librosa computed values rather than the cache.

@samanklesaria
Copy link
Collaborator Author

The next logical thing to try is to get the exact versions of all the packages used in CI and ensure that my local setup (from which I'm generating the comparison files) matches them.

@samanklesaria
Copy link
Collaborator Author

The CI system seems to use numpy 2.2.6 and librosa 0.11.0. I'll pin this and see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant