Skip to content

Commit

Permalink
Add logger for pt2 compile chromium events to hive (#2535)
Browse files Browse the repository at this point in the history
Summary:
X-link: pytorch/pytorch#139941

Pull Request resolved: #2535

Logging raw chromium events to hive per job run enables us to build combined rank perfetto traces without having to depend on Logarithm and deal with things like rate limits etc.

We can easily build a utility to query hive and upload traces to manifold and view them on perfetto

Reviewed By: c00w, jamesjwu

Differential Revision: D65525513

fbshipit-source-id: 95745eafe669cef16a6ad15c66ea5583f9f6a77c
  • Loading branch information
ppanchalia authored and facebook-github-bot committed Nov 14, 2024
1 parent 0ec8bc2 commit 45c50a5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions userbenchmark/dynamo/dynamobench/_dynamo/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
from torch._utils_internal import (
log_chromium_event_internal,
log_compilation_event,
record_chromium_event_internal,
signpost_event,
)
from torch.fx._utils import _format_graph_code, lazy_format_graph_code
Expand Down Expand Up @@ -1175,6 +1176,7 @@ def _log_timed_event(
suppress_context=False,
expect_trace_id=False, # Not every chromium event will have a trace_id
)
record_chromium_event_internal(event)
return event

def log_instant_event(
Expand Down

0 comments on commit 45c50a5

Please sign in to comment.