Cleanup the unused files in the root directory #1819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
The docker building fails. Looks like we also need to update |
|
there is a related issue opencv/opencv-python#885 . We may need to delay the upgrade of numpy. |
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
I see, thanks for digging this up! Will update the PR to keep the same numpy version |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the unused run scripts in the root directory.
Now all scripts that "sweep through models and collect metrics" should be implemented as userbenchmark.
Test upgraded numpy version on nightly docker build:
https://github.com/pytorch/benchmark/actions/runs/5823289368