fix the version of opencv-python #1829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [upstream issue](opencv/opencv-python#885), opencv-python has some compatibility problem with numpy. Since we fixed the numpy version in the requirements.txt, we also need to fix the opencv-python's verison too. I install the nightly Torch and TorchBench, there is an installation error same with the above issue. opencv-python 4.7.0.72 works well. I think we'd better fix its version until the latest opencv-python 4.9.0 released.
xuzhao9
reviewed
Aug 16, 2023
| @@ -17,6 +17,7 @@ pyyaml | |||
| # pytorch build script pins numpy version | |||
| # https://github.com/pytorch/builder/blob/ae5c82e65cb3d8bac6df50e742a195019af91ad3/wheel/build_wheel.sh#L145 | |||
| numpy==1.21.2 | |||
| opencv-python==4.7.0.72 | |||
There was a problem hiding this comment.
Can we add link to the upstream bug here? This is helpful to track why we are adding this constraint and when we can remove it.
There was a problem hiding this comment.
Sorry, I mean to add link to the upstream GitHub issue, not the branch URL.
|
@FindHao has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the upstream issue, opencv-python has a compatibility problem with numpy. Since we fixed the numpy version in the requirements.txt, we also need to fix the opencv-python's verison too. I install the nightly Torch and TorchBench, there is an TorchBench installation error same with the above issue with opencv-python 4.8. But opencv-python 4.7.0.72 works well. I think we'd better fix its version until the latest opencv-python 4.9.0 released.