Remove attention_is_all_you_need and pytorch_struct #1833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
looks good, but can you confirm it would fix the runtime errors in #1832 and link it if so? |
janeyx99
approved these changes
Aug 17, 2023
|
@janeyx99 It should only be related to the missing metrics of nvidia_deeprecommender, attention_is_all_you_need_pytorch, and pytorch_struct. The metric increase in DALLE2_pytorch should be an independent issue. |
|
yes that was why i had specified runtime errors—i will look into the two perf regressions |
xuzhao9
added a commit
that referenced
this pull request
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #1831
Related to the missing metrics in #1832