Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain test.py's NotImplementedErrors #1913

Closed
wants to merge 1 commit into from

Conversation

hmellor
Copy link
Contributor

@hmellor hmellor commented Sep 20, 2023

This helps the user know why a test was skipped and therefore if it was skipped erroneously.

@hmellor hmellor temporarily deployed to docker-s3-upload September 20, 2023 13:26 — with GitHub Actions Inactive
@hmellor hmellor temporarily deployed to docker-s3-upload September 20, 2023 13:27 — with GitHub Actions Inactive
Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 1f70eae.

@hmellor hmellor deleted the more-verbose-skips branch September 26, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants