Add unit tests on CPU for TritonBench features #2323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D58558868 |
|
This pull request was exported from Phabricator. Differential Revision: D58558868 |
jananisriram
added a commit
to jananisriram/benchmark
that referenced
this pull request
Jun 20, 2024
Summary: Pull Request resolved: pytorch#2323 Add unit tests that run on the CPU to verify the behavior of the following: - `x_only = True` for metric registration in [`register_metric()`](https://www.internalfb.com/code/fbsource/[731f07681fbbb38750aee3b165137e39fa6cee50]/fbcode/pytorch/benchmark/torchbenchmark/util/triton_op.py?lines=337) - custom `label` argument for benchmark registration in [`register_benchmark()`](https://www.internalfb.com/code/fbsource/[731f07681fbbb38750aee3b165137e39fa6cee50]/fbcode/pytorch/benchmark/torchbenchmark/util/triton_op.py?lines=316) Reviewed By: xuzhao9 Differential Revision: D58558868
jananisriram
force-pushed
the
export-D58558868
branch
from
9951f4b to
f985e9d
Compare
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
Summary: Pull Request resolved: pytorch#2323 Add unit tests that run on the CPU to verify the behavior of the following: - `x_only = True` for metric registration in [`register_metric()`](https://www.internalfb.com/code/fbsource/[731f07681fbbb38750aee3b165137e39fa6cee50]/fbcode/pytorch/benchmark/torchbenchmark/util/triton_op.py?lines=337) - custom `label` argument for benchmark registration in [`register_benchmark()`](https://www.internalfb.com/code/fbsource/[731f07681fbbb38750aee3b165137e39fa6cee50]/fbcode/pytorch/benchmark/torchbenchmark/util/triton_op.py?lines=316) Reviewed By: xuzhao9 Differential Revision: D58558868
|
This pull request was exported from Phabricator. Differential Revision: D58558868 |
jananisriram
force-pushed
the
export-D58558868
branch
from
f985e9d to
3e9ceec
Compare
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request has been merged in a529b5a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add unit tests that run on the CPU to verify the behavior of the following:
x_only = Truefor metric registration inregister_metric()labelargument for benchmark registration inregister_benchmark()Reviewed By: xuzhao9
Differential Revision: D58558868