Rename optimize_acqf_mixed.py to optimize_mixed.py
#2600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The name `optimize_acqf_mixed` conflicts with the optimizer with the same name, which is exposed in `botorch/optim/__init__.py`. This would lead to `botorch.optim.optimize_acqf_mixed` pointing to two different things. Differential Revision: D65158159
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65158159 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 29, 2024
Summary: X-link: pytorch/botorch#2600 The name `optimize_acqf_mixed` conflicts with the optimizer with the same name, which is exposed in `botorch/optim/__init__.py`. This would lead to `botorch.optim.optimize_acqf_mixed` pointing to two different things. Differential Revision: D65158159
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2600 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 196 196
Lines 17367 17368 +1
=======================================
+ Hits 17365 17366 +1
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 20b7f8d. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Oct 29, 2024
Summary: Pull Request resolved: #2987 X-link: pytorch/botorch#2600 The name `optimize_acqf_mixed` conflicts with the optimizer with the same name, which is exposed in `botorch/optim/__init__.py`. This would lead to `botorch.optim.optimize_acqf_mixed` pointing to two different things. Reviewed By: Balandat Differential Revision: D65158159 fbshipit-source-id: 285977cd3ddd3c8fbed7beb4b778d896d5251ae6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The name
optimize_acqf_mixedconflicts with the optimizer with the same name, which is exposed inbotorch/optim/__init__.py. This would lead tobotorch.optim.optimize_acqf_mixedpointing to two different things.Differential Revision: D65158159