Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying GTest/benchmark locations with -D${packagename}_ROOT #207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iskunk
Copy link

@iskunk iskunk commented Nov 29, 2023

I have my own builds of the GTest and benchmark libraries that I want to use in the cpuinfo build, but the USE_SYSTEM_LIBS option assumes that these are installed in the default compiler/linker paths, without allowing for an alternate location (e.g. somewhere under $HOME or /opt).

This patch enables the standard *_ROOT convention supported by find_package() for these libraries, i.e. -DGTest_ROOT=/path/to/gtest-prefix and -Dbenchmark_ROOT=/path/to/benchmark-prefix.

@facebook-github-bot
Copy link
Contributor

Hi @iskunk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@iskunk
Copy link
Author

iskunk commented Nov 30, 2023

Updated after confirming that the source-download path can also link against GTest::gtest and the like, thus rendering unnecessary the *_LIB variables.

@iskunk
Copy link
Author

iskunk commented Nov 30, 2023

Also confirmed that the INCLUDE_DIRECTORIES() directives are not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants