Update cpuinfo.h: add support for Windows ARM64EC #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
changed the title
xuhancn
approved these changes
Mar 19, 2024
include/cpuinfo.h
Outdated
| @@ -18,15 +18,15 @@ | |||
| #define CPUINFO_ARCH_X86 1 | |||
| #endif | |||
|
|
|||
| #if defined(__x86_64__) || defined(__x86_64) || defined(_M_X64) || defined(_M_AMD64) | |||
| #if defined(__x86_64__) || defined(__x86_64) || (defined(_M_X64) && !defined(_M_ARM64EC)) || (defined(_M_AMD64) && !defined(_M_ARM64EC)) | |||
There was a problem hiding this comment.
I checked https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
MSVC architecture related defination is complex, suggest to add more comments.
malfet
requested changes
May 9, 2024
include/cpuinfo.h
Outdated
| @@ -18,15 +18,15 @@ | |||
| #define CPUINFO_ARCH_X86 1 | |||
| #endif | |||
|
|
|||
| #if defined(__x86_64__) || defined(__x86_64) || defined(_M_X64) || defined(_M_AMD64) | |||
| #if defined(__x86_64__) || defined(__x86_64) || (defined(_M_X64) && !defined(_M_ARM64EC)) || (defined(_M_AMD64) && !defined(_M_ARM64EC)) | |||
There was a problem hiding this comment.
Defining CPUINFO_ARCH_X86_64 for _M_ARM64EC feels wrong, please explain why this is needed
There was a problem hiding this comment.
_M_X64 Defined as the integer literal value 100 for compilations that target x64 processors or ARM64EC. So _M_X64 could be defined when the CPU is actually an ARM CPU.
Here the condition is defined(_M_X64) && !defined(_M_ARM64EC)) . When _M_ARM64EC is 1, the expression is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix a build error:
In short, Arm64EC is a new application binary interface (ABI) for apps running on Arm devices with an x64 like ABI.
Reference: