-
Notifications
You must be signed in to change notification settings - Fork 361
Fix Unisoc T618 Chipset Detection #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add support for uppercase "UNISOC T" prefix in `match_t` function to handle devices like Samsung Galaxy Tab A8 (SM-X205N) that report "UNISOC T618" instead of the expected mixed-case "Unisoc T618". The function now explicitly matches both variants: - "Unisoc T" (mixed case, existing) - "UNISOC T" (uppercase, new) This ensures proper chipset vendor detection on affected Samsung devices where the uppercase variant caused match failures. Includes test case for "UNISOC T618" detection.
Hi @bc-lee! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks okay and consistent with documentation I find on Galaxy Tab A8
With this change does T618 fill in chipset->model correctly?
Does the T618 require any ISA override? Example vudot is problematic on T310
https://github.com/pytorch/cpuinfo/blob/main/src/arm/linux/aarch32-isa.c#L148-L151
I checked out XNNPACK and built and ran all tests on my T618 device. Fortunately, I didn’t encounter any SIGILL issues. The only failures were a few numerical differences in the For reference, here’s an example output from one of the failing scalar-mode tests:
If you have other good ways to validate the instruction set on this device, please let me know. |
Add support for uppercase "UNISOC T" prefix in
match_t
function to handle devices like Samsung Galaxy Tab A8 (SM-X205N) that report "UNISOC T618" instead of the expected mixed-case "Unisoc T618".The function now explicitly matches both variants:
This ensures proper chipset vendor detection on affected Samsung devices where the uppercase variant caused match failures.
Includes test case for "UNISOC T618" detection.
Fixes #306