-
Notifications
You must be signed in to change notification settings - Fork 9.7k
TP SP examples device generalization ( Cuda, XPU, etc.) #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
4b3abaa
cf381e0
d16c819
79f4657
66b83dd
976f270
eb8aa68
8aa4203
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
# Python dependencies required for running the example | ||
|
||
--pre | ||
--extra-index-url https://download.pytorch.org/whl/nightly/cu118 | ||
--extra-index-url https://download.pytorch.org/whl/nightly/cu121 | ||
torch >= 2.3.0.dev0; sys_platform == "linux" | ||
torch >= 2.7.1; sys_platform == "linux" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need all these index urls here? Can we just have:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can make those changes. Although , I do not think that is effecting any of the tests. A maintainer needs to kickoff the 3 tests mentioned below. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still seeing Python 3.8 in the log . Is this file used ? It mentions Python 3.8 specifically. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can a maintainer please kickoff the3 wf's ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Yes, you can always check which workflow file was used here: https://github.com/pytorch/examples/actions/runs/15981567115/workflow So changing this file is a way to go I think. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.8 | ||
3.9 |
Uh oh!
There was an error while loading. Please reload this page.