Update MemoryPlanning Verifier to only assume model has user input if it has at least one tensor input

[jhelsby]

Fixes #10522

Summary

MemoryPlanning verifier currently blows up if all the user inputs are prims. #10522 suggested:

We need to improve the logic of the _do_user_inputs_exist to probably just return false if all the inputs are prims.

This PR implements this suggestion, with accompanying unit tests. _do_user_inputs_exist now returns True if it has at least one tensor input, and False otherwise.

Test plan

Added unit tests to test_memory_planning.py and ran them with

pytest exir/tests/test_memory_planning.py::test_memory_planning.py

Please note you must comment out the line 69 from /pytest.ini for this to work:

--ignore=exir/tests/test_memory_planning.py

On my machine, I also had to comment out line 60 from test_memory_planning.py for the test to run without errors.

torch.ops.load_library("//executorch/kernels/portable:custom_ops_generated_lib")

[The tests I wrote aren't dependent on this library.]

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10617

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures, 2 Unrelated Failures

As of commit 19371e3 with merge base f7c906f ():

NEW FAILURES - The following jobs have failed:

• pull / test-llava-runner-linux / linux-job (gh)
  RuntimeError: Command docker exec -t b5f703b3a1b122beee8db3e6ffdac7783508f7523f9f6e924a806f7460d5d61d /exec failed with exit code 139
• pull / test-models-linux (llama3_2_vision_encoder, portable, linux.4xlarge.memory) / linux-job (gh)
  RuntimeError: Command docker exec -t 87f00dfa45f226fde588b8dd13168dd3b67484a279ad28fd4c9c0d1ce220344e /exec failed with exit code 1
• pull / unittest / linux / linux-job (gh)
  RuntimeError: Command docker exec -t 0ff6bbd4cb5992d0e30b42157cf499d0e78c659e6bd7ee2faa3bbdc24ba94351 /exec failed with exit code 1
• pull / unittest / macos / macos-job (gh)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
• pull / unittest-arm-backend-with-no-fvp (test_pytest_models) / linux-job (gh)
  RuntimeError: Command docker exec -t 99a3029ee6e3e143cbf25a1fa8bf81d9fb02f4e3f5de180f9bcd8367b8141879 /exec failed with exit code 1
• pull / unittest-editable / linux / linux-job (gh)
  RuntimeError: Command docker exec -t 95a32ec881c83d2d6806a873b1d65e0431073e1533dc5371b4d4332ed031338d /exec failed with exit code 1
• trunk / test-arm-backend (test_pytest_models_ethosu_fvp) / linux-job (gh)
  RuntimeError: Command docker exec -t 828759f88e2d0b9f97454e9109abdec41f044da52ca280892df5c2cd2997660e /exec failed with exit code 1
• trunk / test-models-linux-aarch64 (llama3_2_vision_encoder, portable, linux.arm64.2xlarge) / linux-job (gh)
  RuntimeError: Command docker exec -t cc6b2eba978cf1c288d146941358d52f0ab04ffb13647f9eacab1cc3c5a39c13 /exec failed with exit code 1
• trunk / test-models-macos (llama3_2_vision_encoder, portable) / macos-job (gh)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
• trunk / unittest-release / linux / linux-job (gh)
  RuntimeError: Command docker exec -t 768b65ad79c4efa2cab34b1e3f957f77206856d130877a9372376ebc15f4c1f1 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

• pull / unittest-editable / macos / macos-job (gh) (similar failure)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• trunk / unittest-release / macos / macos-job (gh) (trunk failure)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[pytorch-bot]

Didn't find following labels among repository labels: Release notes: exir

[jhelsby]

@pytorchbot label "release notes: exir"

[digantdesai]

Started CI (Need to do for new, external contributions). Rebase please.

Also marked it as Ready to signal reviewers that it's, well, ready for a review. Thanks for the contribution. Welcome to Executorch 😊

[jhelsby]

Thank you, I just rebased. I also fixed the linting issues which the CI tests identified.

[Sorry, I messed this up, hence the subsequent force-push.]

[digantdesai]

cc @JacobSzwejbka can you take a look? 🙏

[larryliu0820]

@JacobSzwejbka gentle ping