[CMake] llm_runner use executorch_core #10698
Merged
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10698
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ec6ec3c with merge base 1984c5f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
requested review from
swolchok,
jackzhxng,
iseeyuan and
larryliu0820
as code owners
lucylq
reviewed
May 5, 2025
lucylq
approved these changes
May 5, 2025
kirklandsign
added
ciflow/trunk
ciflow/binaries
module: build/install
shoumikhin
approved these changes
May 6, 2025
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Currently, _extension_module__srcs has srcs from flat_tensor. This is
bad.
```
set(_extension_module__srcs
extension/flat_tensor/flat_tensor_data_map.cpp
extension/flat_tensor/serialize/flat_tensor_header.cpp
extension/module/module.cpp
)
```
We need to update deps. We need to export extension_flat_tensor to
install directory.
kirklandsign
changed the title
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We only need executorch_core. We don't need prim ops for runner library. runner.exe can add prim_ops separately
Change: