[ET-VK] Using width packed bias in conv1d op to slightly improve speed and memory. #10733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10733
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 86b818d with merge base 1ae8c2c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74208485 |
SS-JIA
approved these changes
May 6, 2025
…mory. (pytorch#10733) Summary: This diff changes bias tensor packing for conv1d op from channels to width packed, which reduces tensor memory footprint and reduces wasted texel fetch. Reviewed By: SS-JIA Differential Revision: D74208485
trivedivivek
force-pushed
the
export-D74208485
branch
from
a89d726 to
86b818d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74208485 |
trivedivivek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff changes bias tensor packing for conv1d op from channels to width packed, which reduces tensor memory footprint and reduces wasted texel fetch.
Differential Revision: D74208485