Skip to content

[RFC] Fetch gflags dynamically #11285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[RFC] Fetch gflags dynamically #11285

wants to merge 4 commits into from

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Jun 2, 2025

Summary

I recently learned about FetchContent. This seems like a nicer solution than using submodules. Thoughts?

Test plan

CI

@jathu jathu added ciflow/trunk ciflow/binaries release notes: none Do not include this in the release notes labels Jun 2, 2025
Copy link

pytorch-bot bot commented Jun 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11285

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 4 Unrelated Failures

As of commit 54685fa with merge base 09a4b9d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2025
@jathu jathu changed the title [WIP] Fetch gflags dynamically [RFC] Fetch gflags dynamically Jun 2, 2025
@jathu jathu force-pushed the jathu/no-gflags branch 3 times, most recently from 5fb5c1b to 1203bce Compare June 3, 2025 21:35
@larryliu0820 larryliu0820 marked this pull request as ready for review June 6, 2025 20:59
@@ -14,6 +14,13 @@ if(BUILD_TESTING)
add_subdirectory(googletest)
endif()

FetchContent_gflags()
# Create a symlink from the gflags source directory to third-party/gflags
message(STATUS "gflags source dir: ${gflags_SOURCE_DIR}")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lets not log, it's too noisy — do we really need to tell them every time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants