-
Notifications
You must be signed in to change notification settings - Fork 583
[RFC] Fetch gflags dynamically #11285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11285
Note: Links to docs will display an error until the docs builds have been completed. ❌ 11 New Failures, 4 Unrelated FailuresAs of commit 54685fa with merge base 09a4b9d ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
5fb5c1b
to
1203bce
Compare
1203bce
to
5cb2e4b
Compare
@@ -14,6 +14,13 @@ if(BUILD_TESTING) | |||
add_subdirectory(googletest) | |||
endif() | |||
|
|||
FetchContent_gflags() | |||
# Create a symlink from the gflags source directory to third-party/gflags | |||
message(STATUS "gflags source dir: ${gflags_SOURCE_DIR}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: lets not log, it's too noisy — do we really need to tell them every time?
Summary
I recently learned about FetchContent. This seems like a nicer solution than using submodules. Thoughts?
Test plan
CI