make operator name consistent before and after serde #12877
Merged
+117
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request resolved: #12462 We need to use the from_node informaton in deserialzied exported graph for operator tracing in et.inspector. this diff updates the serizalier to support serde from_node info. ghstack-source-id: 298666561 Differential Revision: [D78293986](https://our.internmc.facebook.com/intern/diff/D78293986/)
Pull Request resolved: #12531 Node name consistency is important for et because we need to trace the node flow by using node name + graph id + from_node info in the deserialized graph in inspector. Currently we can not have a consistency experience because we didn't record node name as part of schema, but instead, leverging the output info, which didn't record the node name for multiple output node. This diff makes node name as part of schema to ensure the consistency. Also create tests for coverage. ghstack-source-id: 298666560 Differential Revision: [D78380855](https://our.internmc.facebook.com/intern/diff/D78380855/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12877
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 49bb08a with merge base e44da93 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #12531 by @Gasoonjia
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/24/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/24/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/23/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/24/orig
@diff-train-skip-merge