-
Notifications
You must be signed in to change notification settings - Fork 713
Mmap windows #15538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mmap windows #15538
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15538
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 8d2761a with merge base 8c92793 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@JacobSzwejbka has imported this pull request. If you are a Meta employee, you can view this in D86144946. |
| /** | ||
| * Platform-specific file stat function. | ||
| */ | ||
| ET_INLINE int get_file_stat(int fd, size_t* out_size) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, having out_size as a size_t* should not pose an issue as we wouldn't be able to map >4gb on 32bit system anyways, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding the test!
cc @SS-JIA for windows changes as well.
Current windows implementation had issues with 64 bit files. This expands the coverage to work properly and add some tests