Skip to content

Conversation

@oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Nov 4, 2025

Arm tests logged too much as comparisons with logger.level were used instead of logger.getEffectiveLevel(). logger.level will always be logging.NOTSET unless explicitly set with logger.setLevel() which we want to avoid. Instead, we should use logger.getEffectiveLevel() which will inherit the level from its parent.

cc @freddan80 @per @zingo @digantdesai

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15545

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (6 Unrelated Failures)

As of commit dd7c559 with merge base eb409ba (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Nov 4, 2025
Arm tests logged too much as comparisons with logger.level were used
instead of logger.getEffectiveLevel(). logger.level will always be
logging.NOTSET unless explicitly set with logger.setLevel() which we
want to avoid. Instead, we should use logger.getEffectiveLevel() which
will inherit the level from its parent.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: If863593e7dbe455999d5b7bca33cc2511aa3ee50
dump_operator_distribution now prints instead of log to align behavior
with dump_artifact. Also fixes a log-level comparison in
ethosu_backend.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I53eb8dcb1197e420abdb8a635fe2eaad925acaae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant