Skip to content

Conversation

@zingo
Copy link
Collaborator

@zingo zingo commented Nov 4, 2025

Summary

Test was very close the the threshold lets bump rtol so tests pass for now.

Test plan

Test is part of GitHub tests, tests locally over 100 times, way about the previous fail rate of ~15%

cc @freddan80 @per @oscarandersson8218 @digantdesai

@zingo zingo requested a review from digantdesai as a code owner November 4, 2025 10:22
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Nov 4, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15548

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 6 Unrelated Failures

As of commit 0bb415f with merge base bde6b11 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2025
Test was very close the the treshhold lets bump atol so tests pass for now.

Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: I66f126b8c1c710280fc9f1d501f458fb646e5031
@zingo zingo force-pushed the Arm-backend-Bump-atol-for-test_floor_divide_x_FP branch from 13ffb36 to 0bb415f Compare November 4, 2025 11:59
@zingo zingo changed the title Arm backend: Bump atol for test_floor_divide_x_FP Arm backend: Bump rtol for test_floor_divide_x_FP Nov 4, 2025
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failures seem unrelated.

@oscarandersson8218 oscarandersson8218 merged commit 5bcf9af into pytorch:main Nov 4, 2025
288 of 295 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants