Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added CosineAnnealingWarmupRestartsEachCycle scheduler #3048

Closed
wants to merge 1 commit into from

Conversation

sihyeong671
Copy link
Contributor

  • add CosineAnnealingWarmupRestartsEachCycle class in param_scheduler
  • add test function for above class

Fixes #3036

Description:
add new class that following https://github.com/katsura-jp/pytorch-cosine-annealing-with-warmup

I am trying to find way to fix existing CosineAnnealingScheduler class

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

- add CosineAnnealingWarmupRestartsEachCycle class in param_scheduler
- add test function for above class

issue pytorch#3036
@github-actions github-actions bot added the module: handlers Core Handlers module label Aug 29, 2023
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Aug 29, 2023

@sihyeong671 thanks for the PR, I checked quickly the code and according to both classes constructor signatures we might be able to unify them by adding a new flag to CosineAnnealingScheduler

@vfdev-5 vfdev-5 changed the title feat: add new scheduler feat: Added CosineAnnealingWarmupRestartsEachCycle scheduler Aug 29, 2023
@sihyeong671 sihyeong671 deleted the feat/schdueler branch September 16, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: handlers Core Handlers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it good to Add Feature "cosine annealing with warmup restart each cycle"?
2 participants